Treat MERGE_INTO as a status transaction for mail tags
ClosedPublic
Actions

Authored by epriestley on Dec 31 2014, 4:20 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6838: No email notification sent when merging as duplicate, though set for "A task's status changes"

Commits

Restricted Diffusion Commit
rP00192ec8ce50: Treat MERGE_INTO as a status transaction for mail tags

Summary

Fixes T6838. We use a special transaction type for merging, but don't handle it when figuring out mail tags.

Test Plan

Verified merge mail picks up the maniphest-status tag.

Diff Detail

Repository

rP Phabricator

Branch

mergetag

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3415
Build 3422: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26648.Dec 31 2014, 4:20 PM

epriestley retitled this revision from to Treat MERGE_INTO as a status transaction for mail tags.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T6838: No email notification sent when merging as duplicate, though set for "A task's status changes".

Herald added a subscriber: epriestley. · View Herald TranscriptDec 31 2014, 4:20 PM

chad accepted this revision.Dec 31 2014, 4:27 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 31 2014, 4:27 PM

Closed by commit rP00192ec8ce50: Treat MERGE_INTO as a status transaction for mail tags (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2014, 4:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

storage/

ManiphestTransaction.php

1 line

Diff 26648

View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Treat MERGE_INTO as a status transaction for mail tagsClosedPublicActions