Owners - sort repositories alphabetically in path chooser
ClosedPublic
Actions

Authored by btrahan on Dec 30 2014, 10:27 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6834: Order repositories by callsign in "Create package" of Owners

Commits

Restricted Diffusion Commit
rP1c04532852a3: Owners - sort repositories alphabetically in path chooser

Summary

Fixes T6834. Without this asort() call, repositories are ordered by ID, which is arbitrary to the user. This sorts them alphabetically by callsign.

Test Plan

edited a package and saw repos sorted by call sign

Diff Detail

Repository

rP Phabricator

Branch

T6834

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3406
Build 3413: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26634.Dec 30 2014, 10:27 PM

btrahan added a task: T6834: Order repositories by callsign in "Create package" of Owners.

btrahan retitled this revision from to Owners - sort repositories alphabetically in path chooser.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 30 2014, 10:27 PM

chad accepted this revision.Dec 30 2014, 10:28 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2014, 10:28 PM

Closed by commit rP1c04532852a3: Owners - sort repositories alphabetically in path chooser (authored by btrahan, committed by btrahan). · Explain WhyDec 30 2014, 10:28 PM

This revision was automatically updated to reflect the committed changes.

epriestley awarded a token.Dec 30 2014, 11:34 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

controller/

PhabricatorOwnersEditController.php

1 line

Diff 26634

View Options

src/applications/owners/controller/PhabricatorOwnersEditController.php

Owners - sort repositories alphabetically in path chooserClosedPublicActions