Page MenuHomePhabricator

Default remarkup code blocks to plain text, not PHP
ClosedPublic

Authored by epriestley on Dec 30 2014, 6:23 PM.
Tags
None
Referenced Files
F13975435: D11091.diff
Fri, Oct 18, 10:06 AM
F13970707: D11091.id.diff
Thu, Oct 17, 9:27 AM
Unknown Object (File)
Oct 1 2024, 4:31 PM
Unknown Object (File)
Sep 25 2024, 6:27 AM
Unknown Object (File)
Sep 3 2024, 5:30 AM
Unknown Object (File)
Aug 26 2024, 12:06 AM
Unknown Object (File)
Aug 25 2024, 10:16 PM
Unknown Object (File)
Aug 25 2024, 5:50 AM
Subscribers

Details

Summary

Ref T6823. If we have no language information for a block, render it without syntax highlighting instead of with PHP syntax highlighting.

Thinking is to try this, see who notices/complains, and then pursue more tailored defaults if they seem worthwhile.

Test Plan

Wrote a code block with text in it, saw no default highlighting.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Default remarkup code blocks to plain text, not PHP.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 7:16 PM
This revision was automatically updated to reflect the committed changes.