Paths

Table of Contentst

Differential D11070

Define `diff` as a local variable
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:31 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP07dbd520bdef: Define `diff` as a local variable

Summary

This should be a local variable, not a global variable. This silences a few JSHint warnings.

Test Plan

arc lint

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26563.Dec 30 2014, 10:31 AM

joshuaspence retitled this revision from to Define `diff` as a local variable.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:31 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 30 2014, 10:58 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2014, 10:58 AM

Closed by commit rP07dbd520bdef: Define `diff` as a local variable (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 10:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

30 lines

webroot/

rsrc/

js/

application/

differential/

behavior-dropdown-menus.js

2 lines

Diff 26583

View Options

resources/celerity/map.php