Page MenuHomePhabricator

Added defaultBranch to the Repository Dictionary that is returned on conduit calls.
Needs ReviewPublic

Authored by locutus on Dec 29 2014, 10:29 PM.
Tags
None
Referenced Files
F13091962: D11055.diff
Thu, Apr 25, 3:20 AM
Unknown Object (File)
Mon, Apr 8, 5:19 PM
Unknown Object (File)
Wed, Apr 3, 11:03 AM
Unknown Object (File)
Wed, Apr 3, 10:56 AM
Unknown Object (File)
Wed, Apr 3, 10:53 AM
Unknown Object (File)
Jan 6 2024, 10:29 AM
Unknown Object (File)
Dec 26 2023, 10:38 PM
Unknown Object (File)
Dec 26 2023, 6:17 PM

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

To make the Repository Conduit calls provide information needed for automated cloning, this adds the default branch name.

If there are any other areas that this may affect, please warn me. I tested the web interface for conduit and command line.

Test Plan

Make sure conduit returns the needed values.

Diff Detail

Repository
rP Phabricator
Branch
add-default-branch
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 3348
Build 3355: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

locutus retitled this revision from to Added defaultBranch to the Repository Dictionary that is returned on conduit calls..
locutus updated this object.
locutus edited the test plan for this revision. (Show Details)

Even if this doesn't get added to the mainline, I would like a second opinion on how/if this may adversely affect other elements in Phabricator.

I have been testing this on my own test instance and have not seen any issues with arc diff/land/branch/call-conduit I have not seen any issues cloning Repositories through git or browsing them through the web interface. However, I'm concerned I may be overlooking something that could be catastrophic if I deploy.

Is there any other areas that might call on this updated function that could miss-handle the updated return value?

Our testing results: We went ahead an landed this on our fork about a month ago and have not had any issues.