Page MenuHomePhabricator

Differential - tighten up access of Differential data from other applications
ClosedPublic

Authored by btrahan on Dec 19 2014, 10:46 PM.
Tags
None
Referenced Files
F15403214: D11020.id26463.diff
Tue, Mar 18, 2:15 AM
F15401435: D11020.id26464.diff
Mon, Mar 17, 5:42 PM
F15401401: D11020.id.diff
Mon, Mar 17, 5:27 PM
F15397436: D11020.diff
Sun, Mar 16, 8:11 PM
F15379499: D11020.diff
Thu, Mar 13, 9:33 PM
F15334713: D11020.id26463.diff
Sat, Mar 8, 11:39 AM
F15284984: D11020.diff
Tue, Mar 4, 11:10 AM
Unknown Object (File)
Feb 13 2025, 12:24 AM
Subscribers

Details

Summary

Fixes T6790. Turn the old method into "new" (old signature) and "newEphemeral". Deploy "newEphemeral" as many places as possible; basically places we are not in the Differential application *and* have no intentions of ever saving the diff. These callsites are also all places we are just trying to get some changesets at the end of the day.

Test Plan

set differential application policy to 'administrators only'. viewed a commit in diffusion and it worked without any errors! i'm just using my thinkin' noodle on the other code paths.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Differential - tighten up access of Differential data from other applications.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2014, 10:50 PM
This revision was automatically updated to reflect the committed changes.