Page MenuHomePhabricator

Differential - tighten up access of Differential data from other applications
ClosedPublic

Authored by btrahan on Dec 19 2014, 10:46 PM.
Tags
None
Referenced Files
F14059646: D11020.diff
Sun, Nov 17, 8:58 PM
F14049946: D11020.diff
Thu, Nov 14, 3:24 PM
F14034805: D11020.diff
Sun, Nov 10, 2:14 AM
F14021636: D11020.diff
Wed, Nov 6, 10:45 AM
F14010308: D11020.diff
Thu, Oct 31, 7:00 AM
F13983945: D11020.id.diff
Sun, Oct 20, 9:52 AM
Unknown Object (File)
Oct 7 2024, 2:30 PM
Unknown Object (File)
Oct 7 2024, 2:18 PM
Subscribers

Details

Summary

Fixes T6790. Turn the old method into "new" (old signature) and "newEphemeral". Deploy "newEphemeral" as many places as possible; basically places we are not in the Differential application *and* have no intentions of ever saving the diff. These callsites are also all places we are just trying to get some changesets at the end of the day.

Test Plan

set differential application policy to 'administrators only'. viewed a commit in diffusion and it worked without any errors! i'm just using my thinkin' noodle on the other code paths.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Differential - tighten up access of Differential data from other applications.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2014, 10:50 PM
This revision was automatically updated to reflect the committed changes.