This improves the output for some edge cases with %%% blocks. Notably, blocks did not emit a block-level spacing tag, so this:
%%%a%%% %%%b%%%
...rendered on a single line.
Details
Details
Added unit tests.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/markup/engine/remarkup/blockrule/PhutilRemarkupLiteralBlockRule.php | ||
|---|---|---|
| 6–19 | Not sure if this needs to be surfaced in the user-facing remarkup documentation at all or if this is esoteric, etc. just figured i'd call it out in case you hadn't thought of that part yet. | |
Comment Actions
The %%% block itself is documented:
https://secure.phabricator.com/book/phabricator/article/remarkup/#literal-blocks
I think this just makes the rule behave more "naturally" (i.e., do what you'd expect it to do after reading the documentation) so I'm not specifically updating the documentation. If we see user confusion about the behavior of the rule I could make the docs more explicit, but as long as users can figure out how to do what they want after reading the docs I don't want to explain all the parser details if we don't have to.