Page MenuHomePhabricator

Transactions - change show all key from "~" to "@"
ClosedPublic

Authored by btrahan on Dec 12 2014, 7:21 PM.
Tags
None
Referenced Files
F18084610: D10983.id26368.diff
Tue, Aug 5, 4:24 PM
F18015852: D10983.id26370.diff
Sat, Aug 2, 6:01 PM
F17990580: D10983.id26367.diff
Sat, Aug 2, 12:52 AM
F17969614: D10983.id26368.diff
Fri, Aug 1, 2:19 PM
F17961485: D10983.id.diff
Fri, Aug 1, 9:45 AM
F17947896: D10983.diff
Thu, Jul 31, 7:14 PM
F17870112: D10983.diff
Mon, Jul 28, 1:09 PM
Unknown Object (File)
Jul 1 2025, 5:38 PM
Subscribers

Details

Summary

(some) international keyboard layouts can not type "~" in a way as to trigger this so use "@" instead. Save the suggested "+" as that seems like it would be useful for some future "adding stuff" keyboard workflow. Pretty stoked to get this squared away as I am quite confident our unreleased product will now be a huge smashing success. Ref T6683.

Test Plan

made sure my choice was okay via https://en.wikipedia.org/wiki/Dead_key#Dead_keys_on_various_keyboard_layouts; used the "@" key to show all transactions

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - change show all key from "~" to "@".
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2014, 7:23 PM
This revision was automatically updated to reflect the committed changes.