Page MenuHomePhabricator

Read the "hosts" config section from /etc/arcconfig
AbandonedPublic

Authored by staticshock on Dec 12 2014, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 8 2025, 12:19 AM
Unknown Object (File)
Feb 8 2025, 12:19 AM
Unknown Object (File)
Feb 8 2025, 12:19 AM
Unknown Object (File)
Jan 29 2025, 5:14 AM
Unknown Object (File)
Jan 26 2025, 8:24 AM
Unknown Object (File)
Jan 23 2025, 7:06 PM
Unknown Object (File)
Jan 23 2025, 7:06 PM
Unknown Object (File)
Jan 23 2025, 7:06 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This allows storing sensitive info separately from ~/.arcrc, which is convenient for anyone who versions their dotfiles.

Test Plan

Moved my "hosts" section to /etc/arcconfig. Ran arc feature and saw a list of feature branches instead of a certificate error.

Diff Detail

Repository
rARC Arcanist
Branch
config-hosts
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3245
Build 3251: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

staticshock retitled this revision from to Read the "hosts" config section from /etc/arcconfig.
staticshock updated this object.
staticshock edited the test plan for this revision. (Show Details)
staticshock added a reviewer: epriestley.

On second thought, /etc/arcconfig is system-wide, so it's a weird place to store user config.

The two alternatives I can think of are:

  1. Read the certs from a runtime config file, arc --arcrc-file "$HOME/.phabricator-credentials"
  2. Add a mechanism to include secondary arcrc files from ~/.arcrc

+1 on the concept, but yeah. The implementation needs a bit of work