Page MenuHomePhabricator

Fix a stray comma on File previews
ClosedPublic

Authored by epriestley on Dec 11 2014, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 1:24 PM
Unknown Object (File)
Thu, Dec 19, 1:24 PM
Unknown Object (File)
Sat, Dec 7, 11:22 AM
Unknown Object (File)
Wed, Nov 27, 4:25 AM
Unknown Object (File)
Oct 23 2024, 2:20 AM
Unknown Object (File)
Oct 13 2024, 4:14 AM
Unknown Object (File)
Oct 11 2024, 7:23 AM
Unknown Object (File)
Sep 27 2024, 10:23 AM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPbc5598865f62: Fix a stray comma on File previews
Summary

There's a comma to the lower-left of my profile picture here:

Screen_Shot_2014-12-11_at_10.27.37_AM.png (156×417 px, 15 KB)

This is on a page like https://secure.phabricator.com/F248948

What's happening is that some render() method is returning a valid result like array($stuff, null). This is getting passed to JS as an array, which is implicitly join()'ing it into a string, adding a comma.

Instead, make sure we render these to strings on the server side before shipping them to the client.

Test Plan

No more comma on file previews.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a stray comma on File previews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2014, 6:30 PM
This revision was automatically updated to reflect the committed changes.