Page MenuHomePhabricator
Differential D10971

Move 'Query' in Maniphest Search to be above the fold
ClosedPublic
Actions

Authored by chad on Dec 11 2014, 4:51 PM.
Tags
None
Referenced Files
F13087818: D10971.diff
Thu, Apr 25, 1:06 AM
Unknown Object (File)
Fri, Apr 19, 5:37 AM
Unknown Object (File)
Sun, Apr 7, 11:25 AM
Unknown Object (File)
Thu, Apr 4, 1:15 AM
Unknown Object (File)
Mar 24 2024, 12:18 AM
Unknown Object (File)
Mar 24 2024, 12:15 AM
Unknown Object (File)
Mar 23 2024, 11:17 PM
Unknown Object (File)
Mar 23 2024, 11:51 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPf5301e8e9496: Move 'Query' in Maniphest Search to be above the fold
Summary

(Needed a clean branch). Moves the field up and renames to Query

Test Plan

Visit Maniphest Search, see new field, test a query

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 26345.Dec 11 2014, 4:51 PM
chad retitled this revision from to Move 'Query' in Maniphest Search to be above the fold.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 11 2014, 4:51 PM
epriestley edited edge metadata.Dec 11 2014, 4:52 PM

See T4818 for why this is called "Contains Words".

(And this doesn't seem to move the field?)

chad added a comment.Dec 11 2014, 4:53 PM

My branches are messed up. Also, I thought reading the other diff you wanted it to say "Query". Or, why did you request changes if not?

chad updated this revision to Diff 26346.Dec 11 2014, 4:54 PM
chad edited edge metadata.
  • Actually move it, revert to Contains Words
epriestley added a comment.Dec 11 2014, 4:55 PM

D10971 changed the label from "Contains Words" to "Contains Text". This changes it from "Contains Words" to "Query". I would like to keep it as "Contains Words".

It was originally labeled "Contains Text", but changed to "Contains Words" in response to user feedback about "Contains Text" being confusing.

(I think the distinction is fairly silly personally, but that we're better off keeping it.)

epriestley accepted this revision.Dec 11 2014, 4:55 PM
epriestley edited edge metadata.

perfect :3

This revision is now accepted and ready to land.Dec 11 2014, 4:55 PM
chad added a comment.Dec 11 2014, 4:57 PM

Oh, hah, I didn't know I changed that text. I had Query, decided to change it back but picked the wrong words.

Closed by commit rPf5301e8e9496: Move 'Query' in Maniphest Search to be above the fold (authored by chad, committed by chad). · Explain WhyDec 11 2014, 4:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
query/
10 lines

Diff 26347

View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
Phabricator · Built by Phacility