On narrow dashboard columns, don't show col2 of obj-item
ClosedPublic
Actions

Authored by chad on Dec 10 2014, 7:26 PM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP6a0ec944a13a: On narrow dashboard columns, don't show col2 of obj-item

Summary

Hides the second column of info on narrow (33%) columns on dashboards on object-items.

Test Plan

Tested a narrow left and narrow right column, 160px is gained back.

Screen_Shot_2014-12-10_at_11.25.02_AM.png (1×2 px, 470 KB)

Diff Detail

Repository

rP Phabricator

Branch

obj-dashboard-sm

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3217
Build 3223: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26319.Dec 10 2014, 7:26 PM

chad retitled this revision from to On narrow dashboard columns, don't show col2 of obj-item.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 10 2014, 7:26 PM

chad edited the test plan for this revision. (Show Details)Dec 10 2014, 7:26 PM

To clarify, this is just removing the column outright? That seems really bad to me...

It's the column with the dates:

Oh, I thought it was taking out a whole dashboard column and all the panels inside it. That makes more sense.

This revision is now accepted and ready to land.Dec 10 2014, 7:37 PM

In the long run we'll likely need richer means of displaying narrow object lists, maybe bake it directly into obj-item-list at the PHP level. I'll have to think about it a bit. I imagine once we have 3 column and/or project dashboards we'll want something strong than this.

Closed by commit rP6a0ec944a13a: On narrow dashboard columns, don't show col2 of obj-item (authored by chad, committed by chad). · Explain WhyDec 10 2014, 7:41 PM

This revision was automatically updated to reflect the committed changes.