Have home dashboards go to single column on narrow desktops
ClosedPublic
Actions

Authored by chad on Dec 10 2014, 4:40 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T6723: Titles of objects in lists should wrap

Commits

Restricted Diffusion Commit
rP786c7b0df6da: Have home dashboards go to single column on narrow desktops

Summary

Ref T6723. Because of the sidenav, some dashboard layouts may perform poorly on more narrow desktop displays. This provides an additional media query and CSS rules.

Test Plan

Move viewport to 1001 px, see desktop, move to 999 pixels, see tablet-like display.

Screen_Shot_2014-12-10_at_8.35.49_AM.png (782×1 px, 243 KB)

Screen_Shot_2014-12-10_at_8.36.04_AM.png (864×1 px, 289 KB)

Screen_Shot_2014-12-10_at_8.36.15_AM.png (890×2 px, 385 KB)

Diff Detail

Repository

rP Phabricator

Branch

dashboard-width

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3210
Build 3216: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26308.Dec 10 2014, 4:40 PM

chad retitled this revision from to Have home dashboards go to single column on narrow desktops.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T6723: Titles of objects in lists should wrap.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 10 2014, 4:40 PM

chad edited the test plan for this revision. (Show Details)Dec 10 2014, 4:41 PM

epriestley accepted this revision.Dec 10 2014, 4:42 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 10 2014, 4:42 PM

Add a 2-up test

@epriestley I presume if we need this more, maybe a device-desktop-narrow rule?

We could also move the "tablet" breakpoint to 1000px instead of 768px.

Closed by commit rP786c7b0df6da: Have home dashboards go to single column on narrow desktops (authored by chad, committed by chad). · Explain WhyDec 10 2014, 4:51 PM

This revision was automatically updated to reflect the committed changes.

That might not be a bad idea. I can play with how it feels locally for a bit. The main thing is the header changes, which is likely not important to alter anyways at 768.