Paths

Table of Contentst

Differential D10941

Fix an undefined variable
ClosedPublic
Actions

Authored by joshuaspence on Dec 8 2014, 12:10 PM.

Tags

None

Referenced Files

	F14352193: D10941.id26278.diff
	Thu, Dec 19, 1:21 PM

	F14352192: D10941.id26277.diff
	Thu, Dec 19, 1:21 PM

	F14352191: D10941.diff
	Thu, Dec 19, 1:21 PM

	Unknown Object (File)
	Thu, Dec 5, 8:03 AM

	Unknown Object (File)
	Sat, Nov 23, 1:36 PM

	Unknown Object (File)
	Sat, Nov 23, 1:36 PM

	Unknown Object (File)
	Nov 11 2024, 7:31 AM

	Unknown Object (File)
	Oct 24 2024, 9:24 AM

Subscribers

Details

Reviewers

hach-que
epriestley
btrahan

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP9e54e6e88661: Fix an undefined variable

Summary

The $timeline variable is undefined. I was seeing the following error in the logs:

EXCEPTION: (RuntimeException) Undefined variable: timeline at [<phutil>/src/error/PhutilErrorHandler.php:210]
   #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/harbormaster/controller/HarbormasterStepEditController.php:205]
   #1 HarbormasterStepEditController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
   #2 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/webroot/index.php:103]

Test Plan

Created a build step without a fatal error.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26277.Dec 8 2014, 12:10 PM

joshuaspence retitled this revision from to Fix an undefined variable.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, btrahan, hach-que.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 8 2014, 12:10 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 8 2014, 12:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 8 2014, 12:10 PM

Closed by commit rP9e54e6e88661: Fix an undefined variable (authored by joshuaspence, committed by epriestley). · Explain WhyDec 8 2014, 12:11 PM

This revision was automatically updated to reflect the committed changes.

Oops, just pulled this myself.

ohwellok

I have so many unearned internet points

Thanks for fixing this and sorry for the slop!

src/applications/harbormaster/controller/HarbormasterStepEditController.php
192	this xaction_view can probably go if someone needs internet points. :D

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterStepEditController.php

1 line

Diff 26278

src/applications/harbormaster/controller/HarbormasterStepEditController.php

Loading...