Fixes T6690. The editor innards end up loading the conpherence object, whose policy is dictated by these participation objects.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6690: Exception when creating new Conpherence threads
- Commits
- Restricted Diffusion Commit
rP49e53d5709da: Conpherence - fix permissions issue creating new Conpherences
pre patch could not create new conpherences. post patch I can create conpherences! i can also add people to conpherences and it works.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Said policy checks occur here:
And even more specifically, here:
So another fix could be to have that last PhabricatorObjectQuery do a setRaisePolicyExceptions false?
Comment Actions
In the second case, we might just be able to skip that block if the comment isn't being edited? i.e., if $commentVersion === 1, we don't need to do that load? Do we?
Comment Actions
Well, on more thought, I think we need this piece anyway for future proofing. I'll shoot over another diff on the comment version fix.