Differential D10917

Update PHUIObjectItemListView structure for more flexibility
ClosedPublic
Actions

Authored by chad on Dec 2 2014, 6:15 PM.

Tags

None

Referenced Files

	F15423726: D10917.id26224.diff
	Sat, Mar 22, 5:24 PM

	F15422854: D10917.id26223.diff
	Sat, Mar 22, 11:04 AM

	F15389388: D10917.id26223.diff
	Sat, Mar 15, 5:11 AM

	F15369338: D10917.id26223.diff
	Wed, Mar 12, 6:14 AM

	F15283148: D10917.diff
	Tue, Mar 4, 5:34 AM

	Unknown Object (File)
	Sat, Feb 22, 8:26 PM

	Unknown Object (File)
	Feb 15 2025, 9:58 PM

	Unknown Object (File)
	Feb 11 2025, 5:05 AM

Subscribers

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T5502: Make ObjectListItem more resilient

Commits

Restricted Diffusion Commit
rP7aedb3c04e06: Update PHUIObjectItemListView structure for more flexibility

Summary

Converts PHUIObjectItemView to use display: table rows and columns for more flexible layouts. Slightly increases spacing, improves mobile layouts. Fixes T5502

Test Plan

Tested in multiple applications and UIExamples. Ran through mobile, tablet, and desktop break points. Used IE8-IE10, Firefox, Chrome, Safari on both Mac and Windows.

Diff Detail

Repository

Branch

new-phui-object-list

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3162
Build 3168: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26223.Dec 2 2014, 6:15 PM

chad retitled this revision from to Update PHUIObjectItemListView structure for more flexibility.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T5502: Make ObjectListItem more resilient.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 2 2014, 6:15 PM

An example of the cleanup:

Screen_Shot_2014-12-02_at_10.16.24_AM.png (560×1 px, 149 KB)

Screen_Shot_2014-12-02_at_10.16.42_AM.png (912×1 px, 238 KB)

I tables

This revision is now accepted and ready to land.Dec 2 2014, 6:18 PM

Sadly, it seems like http://giveupandusetables.com is defunct.

Closed by commit rP7aedb3c04e06: Update PHUIObjectItemListView structure for more flexibility (authored by chad, committed by chad). · Explain WhyDec 2 2014, 6:25 PM

This revision was automatically updated to reflect the committed changes.

if you want to roll secure, i'll poke there for any other display bugs.

Rolled it.

yippie-ki-yay.jpg (550×413 px, 60 KB)

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

view/

phui/

PHUIObjectItemView.php

46 lines

webroot/

rsrc/

css/

phui/

phui-object-item-list-view.css

184 lines

Diff 26223

resources/celerity/map.php

Loading...

src/view/phui/PHUIObjectItemView.php

Loading...

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...