Page MenuHomePhabricator
Differential D10910

Differential - fix "transaction has no effect error" on diff create
ClosedPublic
Actions

Authored by btrahan on Dec 1 2014, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 4:59 PM
Unknown Object (File)
Dec 19 2024, 1:50 PM
Unknown Object (File)
Dec 19 2024, 1:50 PM
Unknown Object (File)
Dec 19 2024, 1:17 PM
Unknown Object (File)
Dec 16 2024, 5:38 PM
Unknown Object (File)
Dec 13 2024, 9:19 PM
Unknown Object (File)
Dec 13 2024, 8:28 PM
Unknown Object (File)
Dec 4 2024, 4:03 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T6658: Unhandled Exception ("PhabricatorApplicationTransactionNoEffectException") while creating diff via web interface
Commits
Restricted Diffusion Commit
rP608137039150: Differential - fix "transaction has no effect error" on diff create
Summary

Fixes T6658.

Test Plan

made a diff with no repository and default policy and it worked!

Diff Detail

Repository
rP Phabricator
Branch
T6658
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3153
Build 3159: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26207.Dec 1 2014, 8:02 PM
btrahan added a task: T6658: Unhandled Exception ("PhabricatorApplicationTransactionNoEffectException") while creating diff via web interface.
btrahan retitled this revision from to Differential - fix "transaction has no effect error" on diff create.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 1 2014, 8:02 PM
Harbormaster completed remote builds in B3153: Diff 26207.Dec 1 2014, 8:03 PM
chad accepted this revision.Dec 1 2014, 8:04 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2014, 8:04 PM
Closed by commit rP608137039150: Differential - fix "transaction has no effect error" on diff create (authored by btrahan, committed by btrahan). · Explain WhyDec 1 2014, 8:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
1 line
1 line

Diff 26207

View Options

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

Loading...
View Options

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility