Differential - fix "transaction has no effect error" on diff create
ClosedPublic
Actions

Authored by btrahan on Dec 1 2014, 8:02 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6658: Unhandled Exception ("PhabricatorApplicationTransactionNoEffectException") while creating diff via web interface

Commits

Restricted Diffusion Commit
rP608137039150: Differential - fix "transaction has no effect error" on diff create

Summary

Fixes T6658.

Test Plan

made a diff with no repository and default policy and it worked!

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26207.Dec 1 2014, 8:02 PM

btrahan added a task: T6658: Unhandled Exception ("PhabricatorApplicationTransactionNoEffectException") while creating diff via web interface.

btrahan retitled this revision from to Differential - fix "transaction has no effect error" on diff create.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 1 2014, 8:02 PM

Harbormaster completed remote builds in B3153: Diff 26207.Dec 1 2014, 8:03 PM

chad accepted this revision.Dec 1 2014, 8:04 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 1 2014, 8:04 PM

Closed by commit rP608137039150: Differential - fix "transaction has no effect error" on diff create (authored by btrahan, committed by btrahan). · Explain WhyDec 1 2014, 8:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialCreateDiffConduitAPIMethod.php

1 line

DifferentialCreateRawDiffConduitAPIMethod.php

1 line

Diff 26209

View Options

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php