Page MenuHomePhabricator
Differential D10906

Show 'Unsubmitted comments' speech bubble for audits
AbandonedPublic
Actions

Authored by epriestley on Nov 28 2014, 7:56 AM.
Tags
None
Referenced Files
F13197504: D10906.diff
Mon, May 13, 12:14 AM
F13178778: D10906.diff
Wed, May 8, 8:41 PM
Unknown Object (File)
Thu, Apr 25, 3:43 AM
Unknown Object (File)
Apr 11 2024, 10:51 AM
Unknown Object (File)
Apr 1 2024, 2:25 AM
Unknown Object (File)
Feb 11 2024, 10:08 AM
Unknown Object (File)
Feb 7 2024, 9:35 AM
Unknown Object (File)
Jan 10 2024, 3:57 PM
View All Files
Subscribers
epriestley
joshuaspence
Korvin

Details

Reviewers
aik099
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6660: Unsubmitted comments icon for Audits
Summary

Fixes T6660

Test Plan
  1. add an inline comment to a commit
  2. don't publish it using large Submit button at the page bottom
  3. go to list of Audits (or Dashboard if there is panel showing Audits)
  4. see speech bubble icon in the 2nd line (leftmost part) for that commit

Diff Detail

Repository
rP Phabricator
Branch
tmp-branch
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3146
Build 20072: Run Core Tests
Build 3152: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

aik099 updated this revision to Diff 26200.Nov 28 2014, 7:56 AM
aik099 retitled this revision from to Show 'Unsubmitted comments' speech bubble for audits.
aik099 updated this object.
aik099 edited the test plan for this revision. (Show Details)
aik099 added a reviewer: epriestley.
aik099 added a task: T6660: Unsubmitted comments icon for Audits.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 28 2014, 7:56 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
Harbormaster completed remote builds in B3146: Diff 26200.Nov 28 2014, 7:57 AM
joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 11:59 PM
epriestley commandeered this revision.Jan 14 2017, 5:06 PM
epriestley edited reviewers, added: aik099; removed: epriestley.
Harbormaster failed remote builds in B3146: Diff 26200!Jan 14 2017, 5:07 PM
epriestley abandoned this revision.Jan 14 2017, 5:30 PM

Obsoleted by D17208.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
query/
3 lines
view/
19 lines
diffusion/
query/
22 lines
home/
controller/
2 lines
repository/
storage/
10 lines

Diff 26200

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/audit/view/PhabricatorAuditListView.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
Phabricator · Built by Phacility