Remove inner spacing on mozilla-based buttons
ClosedPublic
Actions

Authored by chad on Nov 26 2014, 12:08 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T6644: Actions menu <button> rendering issue in Firefox

Commits

Restricted Diffusion Commit
rPfa77fdd168d4: Remove inner spacing on mozilla-based buttons

Summary

Fixes T6644

Test Plan

Tested buttons in FF and Chrome

Before:

Screen_Shot_2014-11-25_at_4.07.47_PM.png (162×412 px, 17 KB)

After:

Screen_Shot_2014-11-25_at_4.08.04_PM.png (210×432 px, 17 KB)

Diff Detail

Repository

rP Phabricator

Branch

ff-lolzy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3143
Build 3149: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26191.Nov 26 2014, 12:08 AM

chad retitled this revision from to Remove inner spacing on mozilla-based buttons.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T6644: Actions menu <button> rendering issue in Firefox.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 26 2014, 12:08 AM

chad edited the test plan for this revision. (Show Details)Nov 26 2014, 12:09 AM

Harbormaster completed remote builds in B3143: Diff 26191.Nov 26 2014, 12:09 AM

chad edited the test plan for this revision. (Show Details)Nov 26 2014, 12:09 AM

epriestley accepted this revision.Nov 26 2014, 1:56 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 26 2014, 1:56 AM

Closed by commit rPfa77fdd168d4: Remove inner spacing on mozilla-based buttons (authored by chad, committed by chad). · Explain WhyNov 26 2014, 2:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-button.css

5 lines

Diff 26191

View Options

resources/celerity/map.php