Page MenuHomePhabricator
Differential D10884

Add ReallyMajorEvent to PHUITimelineView
ClosedPublic
Actions

Authored by chad on Nov 20 2014, 12:47 AM.
Tags
None
Referenced Files
F14852059: D10884.diff
Tue, Feb 4, 10:01 PM
Unknown Object (File)
Mon, Jan 27, 8:05 AM
Unknown Object (File)
Thu, Jan 23, 5:40 AM
Unknown Object (File)
Tue, Jan 21, 10:05 AM
Unknown Object (File)
Fri, Jan 17, 10:44 PM
Unknown Object (File)
Fri, Jan 17, 9:52 PM
Unknown Object (File)
Mon, Jan 13, 10:18 AM
Unknown Object (File)
Sun, Jan 12, 7:30 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPd908e7673345: Add ReallyMajorEvent to PHUITimelineView
Summary

For actions like "Close" that are in theory stopping the timeline, we should display some disruption to the line itself.

Test Plan

Tested in UIExamples

Screen_Shot_2014-11-19_at_4.45.23_PM.png (552×760 px, 84 KB)

Diff Detail

Repository
rP Phabricator
Branch
timeline-spacer
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3108
Build 3114: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26138.Nov 20 2014, 12:47 AM
chad retitled this revision from to Add ReallyMajorEvent to PHUITimelineView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 20 2014, 12:47 AM
chad edited the test plan for this revision. (Show Details)Nov 20 2014, 12:47 AM
Harbormaster completed remote builds in B3108: Diff 26138.Nov 20 2014, 12:47 AM
epriestley accepted this revision.Nov 21 2014, 12:25 AM
epriestley edited edge metadata.

Not totally sold on this yet but let's give it a shot.

This revision is now accepted and ready to land.Nov 21 2014, 12:25 AM
chad added a comment.Nov 21 2014, 12:32 AM

Yeah I read through as few really long Github Issues the other day and it caught my eye (as it was intended). When you're quickly scanning a long task it's a nice detail that helps orient you. https://github.com/twbs/bootstrap/issues/13823

Closed by commit rPd908e7673345: Add ReallyMajorEvent to PHUITimelineView (authored by chad, committed by chad). · Explain WhyNov 21 2014, 12:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
uiexample/
examples/
25 lines
view/
phui/
41 lines
webroot/
rsrc/
css/
phui/
9 lines

Diff 26138

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUITimelineExample.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility