Page MenuHomePhabricator
Differential D10883

Add email preference links to email footers
ClosedPublic
Actions

Authored by lpriestley on Nov 20 2014, 12:33 AM.
Tags
None
Referenced Files
F14351770: D10883.diff
Thu, Dec 19, 10:12 AM
Unknown Object (File)
Mon, Dec 16, 10:02 PM
Unknown Object (File)
Thu, Dec 12, 6:17 PM
Unknown Object (File)
Mon, Dec 9, 11:41 AM
Unknown Object (File)
Nov 13 2024, 10:42 PM
Unknown Object (File)
Nov 10 2024, 7:09 AM
Unknown Object (File)
Nov 10 2024, 7:09 AM
Unknown Object (File)
Nov 4 2024, 4:34 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPf7aa87311ae5: Add email preference links to email footers
Summary

Ref T1217, Add link to email preferences to email template

Test Plan

Add comment to object like Maniphest task, check that email has a footer with a link to email preferences.

Diff Detail

Repository
rP Phabricator
Branch
emailpreferencelink
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3110
Build 3116: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 26137.Nov 20 2014, 12:33 AM
lpriestley retitled this revision from to Add email preference links to email footers.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: Restricted Maniphest Task.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 20 2014, 12:33 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
Harbormaster completed remote builds in B3107: Diff 26137.Nov 20 2014, 12:34 AM
epriestley requested changes to this revision.Nov 20 2014, 12:35 AM
epriestley edited edge metadata.

One inline.

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
195–202

Just call:

$this->addLinkSection(pht('EMAIL PREFERENCES'), $href);
This revision now requires changes to proceed.Nov 20 2014, 12:35 AM
lpriestley updated this revision to Diff 26140.Nov 20 2014, 1:03 AM
lpriestley edited edge metadata.

Switching to build in addLinkSection()

Harbormaster completed remote builds in B3110: Diff 26140.Nov 20 2014, 1:04 AM
epriestley accepted this revision.Nov 20 2014, 1:05 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 20 2014, 1:05 AM
Closed by commit rPf7aa87311ae5: Add email preference links to email footers (authored by lpriestley, committed by epriestley). · Explain WhyNov 20 2014, 1:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
option/
14 lines
metamta/
view/
17 lines
transactions/
editor/
3 lines

Diff 26140

View Options

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

Loading...
View Options

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility