Differential D10880

Fix almanac.queryservices for no results
ClosedPublic
Actions

Authored by epriestley on Nov 19 2014, 11:15 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5833: Build "Almanac", a service/host/device directory

Commits

Restricted Diffusion Commit
rP15ab2141da15: Fix almanac.queryservices for no results

Summary

Ref T5833. We try to load bindings even if we get no services back.

Test Plan

Queried invalid results.

Diff Detail

Repository

rP Phabricator

Branch

noservices

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3103
Build 3109: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26130.Nov 19 2014, 11:15 PM

epriestley retitled this revision from to Fix almanac.queryservices for no results.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5833: Build "Almanac", a service/host/device directory.

Herald added a subscriber: epriestley. · View Herald TranscriptNov 19 2014, 11:15 PM

Harbormaster completed remote builds in B3103: Diff 26130.Nov 19 2014, 11:16 PM

btrahan accepted this revision.Nov 19 2014, 11:16 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Nov 19 2014, 11:16 PM

Closed by commit rP15ab2141da15: Fix almanac.queryservices for no results (authored by epriestley, committed by epriestley). · Explain WhyNov 19 2014, 11:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

conduit/

AlmanacQueryServicesConduitAPIMethod.php

14 lines

Diff 26130

View Options

src/applications/almanac/conduit/AlmanacQueryServicesConduitAPIMethod.php

Fix almanac.queryservices for no resultsClosedPublicActions