Diffusion - make projects work properly with commits
ClosedPublic
Actions

Authored by btrahan on Nov 19 2014, 10:20 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T3189: [feature request] Tag commits

Commits

Restricted Diffusion Commit
rPa414fc497f3b: Diffusion - make projects work properly with commits

Summary

Fixes T3189. Now if you say Projects in a commit message they will associate nicely with the commit. Also we record transactions about all this project editing fun.

Test Plan

tested migration by associating some projects with commits and verifying they still showed up post migration. tested adding / removing projects by doing so from the UI, noting transactions written nicely as well

Diff Detail

Repository

rP Phabricator

Branch

T3189

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3099
Build 3105: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26123.Nov 19 2014, 10:20 PM

btrahan added a task: T3189: [feature request] Tag commits.

btrahan retitled this revision from to Diffusion - make projects work properly with commits.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a project: Projects.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 19 2014, 10:20 PM

Harbormaster completed remote builds in B3097: Diff 26123.Nov 19 2014, 10:20 PM

Can we remove the edge constants completely?

I think the bit in PhabricatorRepositoryCommitSearchIndexer which reads them can be safely removed (should be automatic with PhabricatorProjectInterface, or we should make it automatic if it isn't).

This revision is now accepted and ready to land.Nov 19 2014, 10:28 PM

epriestley awarded a token.Nov 19 2014, 10:30 PM

nuke edge constants
make all objects of type PhabricatorProjectInterface index their project relationships
- remove extra code manually doing this in Maniphest as well as here in Diffusion

Harbormaster completed remote builds in B3099: Diff 26125.Nov 19 2014, 10:39 PM