Don't compute a nonsensical assigned task count for logged-out users
ClosedPublic
Actions

Authored by epriestley on Nov 19 2014, 9:00 PM.

Details

Reviewers

btrahan
• chasemp
chad

Commits

Restricted Diffusion Commit
rPcd406948fec7: Don't compute a nonsensical assigned task count for logged-out users

Summary

When a logged-out user views the home page, we currently compute a meaningless "assigned tasks" count which just counts every open task. Don't do this.

Ideally ManiphestTaskQuery should get some tightening up too (that is, withOwners(array(null)) should not select every task), but that might affect other stuff and the performance implications of counting every open task are affecting WMF, so just fix the immediate issue for now.

Test Plan

Viewed homepage as a logged out user, no assigned task count.
Viewed homepage as a logged-in user, still saw assigned task count.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26121.Nov 19 2014, 9:00 PM

epriestley retitled this revision from to Don't compute a nonsensical assigned task count for logged-out users.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad, • chasemp.

Herald added a subscriber: epriestley. · View Herald TranscriptNov 19 2014, 9:00 PM

Harbormaster completed remote builds in B3096: Diff 26121.Nov 19 2014, 9:01 PM

I guess withOwners(array(null)) is internal shorthand for "unowned", so this is actually just counting unassigned tasks. Still broken and junky but the API which allowed the error is at least somewhat defensible.

20after4 added a subscriber: 20after4.Nov 19 2014, 9:03 PM