Page MenuHomePhabricator

Don't compute a nonsensical assigned task count for logged-out users
ClosedPublic

Authored by epriestley on Nov 19 2014, 9:00 PM.
Tags
None
Referenced Files
F13345917: D10876.diff
Fri, Jun 21, 12:03 PM
F13334340: D10876.id.diff
Tue, Jun 18, 8:31 PM
F13332242: D10876.diff
Mon, Jun 17, 9:26 AM
F13327660: D10876.id.diff
Sat, Jun 15, 7:56 PM
F13238474: D10876.id26122.diff
May 21 2024, 7:28 PM
F13228703: D10876.id26121.diff
May 20 2024, 11:26 AM
F13218221: D10876.id.diff
May 18 2024, 11:06 AM
F13202083: D10876.diff
May 14 2024, 9:31 PM
Tokens
"Mountain of Wealth" token, awarded by 20after4.

Details

Summary

When a logged-out user views the home page, we currently compute a meaningless "assigned tasks" count which just counts every open task. Don't do this.

Ideally ManiphestTaskQuery should get some tightening up too (that is, withOwners(array(null)) should not select every task), but that might affect other stuff and the performance implications of counting every open task are affecting WMF, so just fix the immediate issue for now.

Test Plan
  • Viewed homepage as a logged out user, no assigned task count.
  • Viewed homepage as a logged-in user, still saw assigned task count.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't compute a nonsensical assigned task count for logged-out users.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad, chasemp.

I guess withOwners(array(null)) is internal shorthand for "unowned", so this is actually just counting unassigned tasks. Still broken and junky but the API which allowed the error is at least somewhat defensible.

chasemp edited edge metadata.

Thank you for your expediciousness :)

This revision is now accepted and ready to land.Nov 19 2014, 9:05 PM
This revision was automatically updated to reflect the committed changes.