Page MenuHomePhabricator
Differential D10873

[drydock/core] Show blueprints / resources as links in Drydock view controllers
ClosedPublic
Actions

Authored by hach-que on Nov 19 2014, 3:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 6:20 PM
Unknown Object (File)
Fri, Dec 20, 2:55 PM
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 1:46 PM
View All Files
Subscribers
devurandom
epriestley
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Commits
Restricted Diffusion Commit
rP0a3714507208: [drydock/core] Show blueprints / resources as links in Drydock view controllers
Summary

Ref T2015. This updates the blueprint / resource references in the Drydock view controllers to render as handles.

Test Plan

Viewed the controllers, saw links.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hach-que updated this revision to Diff 26112.Nov 19 2014, 3:32 AM
hach-que retitled this revision from to Show blueprints / resources as links in Drydock view controllers.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T2015: Implement Drydock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2014, 3:32 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
Harbormaster completed remote builds in B3089: Diff 26112.Nov 19 2014, 3:32 AM
joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 7:32 AM
devurandom added a subscriber: devurandom.Mar 2 2015, 8:38 PM
epriestley requested changes to this revision.Aug 8 2015, 6:34 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/drydock/controller/DrydockLeaseViewController.php
147

Just use $viewer->renderHandle() in modern code.

148–152

This branch is unreachable: HandleQuery never returns null.

156

This will render "Unknown Resource" for a lease with no resource, which I believe is possible and which seems wrong?

src/applications/drydock/controller/DrydockResourceViewController.php
120–133 ↗(On Diff #26112)

Just use $viewer->renderHandle($resource->getBlueprintPHID()).

This revision now requires changes to proceed.Aug 8 2015, 6:34 PM
hach-que updated this revision to Diff 33757.Aug 24 2015, 10:24 AM
hach-que edited edge metadata.

Made requested changes

hach-que updated this revision to Diff 33768.Aug 24 2015, 12:15 PM
hach-que edited edge metadata.

Rebase

hach-que retitled this revision from Show blueprints / resources as links in Drydock view controllers to [drydock/core] Show blueprints / resources as links in Drydock view controllers.Aug 24 2015, 12:22 PM
epriestley accepted this revision.Sep 23 2015, 5:51 PM
epriestley edited edge metadata.

I think I got one of these but let me see what else merges cleanly.

This revision is now accepted and ready to land.Sep 23 2015, 5:51 PM
Closed by commit rP0a3714507208: [drydock/core] Show blueprints / resources as links in Drydock view controllers (authored by epriestley, committed by epriestley). · Explain WhySep 23 2015, 5:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
controller/
17 lines
phid/
7 lines

Diff 34180

View Options

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...
View Options

src/applications/drydock/phid/DrydockResourcePHIDType.php

Loading...
Phabricator · Built by Phacility