Set the status of DrydockResource to BROKEN instead of performing a hard-delete
AbandonedPublic
Actions

Authored by hach-que on Nov 18 2014, 11:45 PM.

Details

Reviewers

Group Reviewers

Summary

This sets the status of DrydockResource to BROKEN instead of performing a hard-delete. This ensures you can still view leases associated with builds and view leases in Drydock even if allocation fails.

Test Plan

Tested this with 5 leases waiting for the same resource, and having that resource fail allocation. Saw the expected result.

Diff Detail

Repository

rP Phabricator

Branch

drydock-no-delete

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3086
Build 3092: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 26108.Nov 18 2014, 11:45 PM

hach-que retitled this revision from to Set the status of DrydockResource to BROKEN instead of performing a hard-delete.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 18 2014, 11:45 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B3085: Diff 26108.Nov 18 2014, 11:45 PM

Tested

Harbormaster completed remote builds in B3086: Diff 26109.Nov 19 2014, 12:11 AM

hach-que updated this object.Nov 19 2014, 12:12 AM

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.Nov 19 2014, 12:24 AM

joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 7:32 AM

Depends on a bunch of other code. These changes are probably better just merged into those other diffs.

This revision now requires changes to proceed.Aug 8 2015, 6:27 PM

hach-que mentioned this in D10304: [drydock/core] Implement resource constraints and correct locking mechanisms with yielding for Drydock.Aug 24 2015, 10:08 AM

Merged into D10304.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

blueprint/

DrydockAmazonEC2HostBlueprintImplementation.php

7 lines

worker/

DrydockAllocatorWorker.php

3 lines

Diff 26109

View Options

src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php