Page MenuHomePhabricator
Differential D10868

Don't show "View Wiki" reminder link if viewer has no access to Phriction
ClosedPublic
Actions

Authored by epriestley on Nov 18 2014, 7:24 PM.
Tags
None
Referenced Files
F15532344: D10868.id26102.diff
Wed, Apr 23, 3:36 PM
F15527920: D10868.id26101.diff
Tue, Apr 22, 7:32 AM
F15527616: D10868.id.diff
Tue, Apr 22, 5:11 AM
F15526210: D10868.diff
Mon, Apr 21, 8:02 PM
F15479470: D10868.diff
Tue, Apr 8, 7:30 AM
F15475169: D10868.id26101.diff
Sun, Apr 6, 4:46 PM
F15417941: D10868.diff
Mar 20 2025, 7:37 PM
F15416475: D10868.id26101.diff
Mar 20 2025, 11:23 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled
Commits
Restricted Diffusion Commit
rPedf88225f5bb: Don't show "View Wiki" reminder link if viewer has no access to Phriction
Summary

Fixes T6581.

Test Plan
  • Loaded project page with Phriction accessible, saw link.
  • Loaded project page with Phriction uninstalled, no link.

Diff Detail

Repository
rP Phabricator
Branch
nowiki
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3080
Build 3086: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26101.Nov 18 2014, 7:24 PM
epriestley retitled this revision from to Don't show "View Wiki" reminder link if viewer has no access to Phriction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled.
Herald added a subscriber: epriestley. · View Herald TranscriptNov 18 2014, 7:24 PM
Harbormaster completed remote builds in B3080: Diff 26101.Nov 18 2014, 7:25 PM
chad accepted this revision.Nov 18 2014, 7:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2014, 7:32 PM
Closed by commit rPedf88225f5bb: Don't show "View Wiki" reminder link if viewer has no access to Phriction (authored by epriestley, committed by epriestley). · Explain WhyNov 18 2014, 7:41 PM
This revision was automatically updated to reflect the committed changes.
• talal123 edited tasks, added T6586: Show an error in Harbormaster plan viewer if more than one step outputs the same artifact; removed T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled.Nov 19 2014, 6:37 AM
cburroughs added a task: T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled.Nov 19 2014, 3:31 PM
epriestley removed a task: T6586: Show an error in Harbormaster plan viewer if more than one step outputs the same artifact.Nov 19 2014, 5:02 PM

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
17 lines

Diff 26101

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
Phabricator · Built by Phacility