Don't show "View Wiki" reminder link if viewer has no access to Phriction
ClosedPublic
Actions

Authored by epriestley on Nov 18 2014, 7:24 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled

Commits

Restricted Diffusion Commit
rPedf88225f5bb: Don't show "View Wiki" reminder link if viewer has no access to Phriction

Summary

Fixes T6581.

Test Plan

Loaded project page with Phriction accessible, saw link.
Loaded project page with Phriction uninstalled, no link.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26101.Nov 18 2014, 7:24 PM

epriestley retitled this revision from to Don't show "View Wiki" reminder link if viewer has no access to Phriction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled.

Herald added a subscriber: epriestley. · View Herald TranscriptNov 18 2014, 7:24 PM

Harbormaster completed remote builds in B3080: Diff 26101.Nov 18 2014, 7:25 PM

chad accepted this revision.Nov 18 2014, 7:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 18 2014, 7:32 PM

Closed by commit rPedf88225f5bb: Don't show "View Wiki" reminder link if viewer has no access to Phriction (authored by epriestley, committed by epriestley). · Explain WhyNov 18 2014, 7:41 PM

This revision was automatically updated to reflect the committed changes.

• talal123 edited tasks, added T6586: Show an error in Harbormaster plan viewer if more than one step outputs the same artifact; removed T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled.Nov 19 2014, 6:37 AM

cburroughs added a task: T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled.Nov 19 2014, 3:31 PM

epriestley removed a task: T6586: Show an error in Harbormaster plan viewer if more than one step outputs the same artifact.Nov 19 2014, 5:02 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectProfileController.php

17 lines

Diff 26102

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Don't show "View Wiki" reminder link if viewer has no access to PhrictionClosedPublicActions