Page MenuHomePhabricator
Differential D10858

Make default profile image configurable
AbandonedPublic
Actions

Authored by valhallasw on Nov 15 2014, 1:15 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Feb 14, 11:01 AM
Unknown Object (File)
Sat, Feb 8, 12:06 AM
Unknown Object (File)
Sat, Feb 8, 12:06 AM
Unknown Object (File)
Sat, Feb 8, 12:06 AM
Unknown Object (File)
Sat, Feb 8, 12:06 AM
Unknown Object (File)
Sat, Feb 8, 12:06 AM
Unknown Object (File)
Fri, Feb 7, 9:36 AM
Unknown Object (File)
Thu, Jan 30, 7:20 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

For Wikimedia, we'd like to use a wikimedia logo instead of a Psyduck.

NOTE: this commit is not ready as-is. For some reason, the 'use default' image at /people/picture/ stays a Psyduck.

In addition, we could consider adding support for:

  • PHIDs instead of Fxx
  • external urls
  • 'celerity:///' urls for the default avatar / other avatars one could distribute that way
Test Plan

Change users.default-avatar to a File. Notice the image changes.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3063
Build 3069: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

valhallasw updated this revision to Diff 26070.Nov 15 2014, 1:15 PM
valhallasw retitled this revision from to Make default profile image configurable.
valhallasw updated this object.
valhallasw edited the test plan for this revision. (Show Details)
valhallasw added a project: Wikimedia.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 15 2014, 1:15 PM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B3061: Diff 26070.Nov 15 2014, 1:16 PM
valhallasw updated this revision to Diff 26071.Nov 15 2014, 1:17 PM
valhallasw edited edge metadata.

Fix default value

Harbormaster completed remote builds in B3062: Diff 26071.Nov 15 2014, 1:18 PM
valhallasw updated this revision to Diff 26072.Nov 15 2014, 1:46 PM

Use PhabricatorUser::defaultProfileImageURI to show the default image in the edit window

epriestley requested changes to this revision.Nov 15 2014, 1:47 PM
epriestley added a reviewer: epriestley.

Sorry, we're not interested in pursuing this change in the upstream. See:

https://secure.phabricator.com/book/phabcontrib/article/contributing_code/

You can replace this file locally. You may also need to replace /resources/builtin/profile.png and destroy the File object which caches it (see PhabricatorFile::loadBuiltin()).

This revision now requires changes to proceed.Nov 15 2014, 1:47 PM
Harbormaster completed remote builds in B3063: Diff 26072.Nov 15 2014, 1:47 PM
valhallasw abandoned this revision.Dec 16 2014, 1:41 PM

Revision Contents
Changeset List

PathSize
src/
applications/
people/
config/
3 lines
controller/
4 lines
storage/
8 lines

Diff 26072

View Options

src/applications/people/config/PhabricatorUserConfigOptions.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility