Audit - delete duplicate audit requests and add unique key
ClosedPublic
Actions

Authored by btrahan on Nov 14 2014, 12:06 AM.

Details

Reviewers

epriestley

Maniphest Tasks

Restricted Maniphest Task

Commits

Summary

Fixes T1768. This is mostly a data cleanliness issue as duplicate rows don't really do anything, but let's clear it up now.

Test Plan

made some duplicate rows by adding the same auditor multiple times. ran ./bin/storage upgrade and it worked perfectly!

Repository

rP Phabricator

Branch

T1768

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3046
Build 3052: [Placeholder Plan] Wait for 30 Seconds

btrahan added a task: Restricted Maniphest Task.

btrahan retitled this revision from to Audit - delete duplicate audit requests and add unique key.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

resources/sql/autopatches/20141113.auditdupes.php
1–24	the algorithm is "keep the first one from the liskmigrationiterator"

Yep, perfect. Rule seems reasonable to me.

resources/sql/autopatches/20141113.auditdupes.php
20	Technically redundant.
src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php
30	Maybe call this `key_unique` or something -- I've been trying to move names to `key_...` to make them unambiguous vs columns.