Paths

Table of Contentst

Differential D10849

Audit - delete duplicate audit requests and add unique key
ClosedPublic
Actions

Authored by btrahan on Nov 14 2014, 12:06 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 1:44 PM

	Unknown Object (File)
	Thu, Dec 19, 1:44 PM

	Unknown Object (File)
	Thu, Dec 19, 1:44 PM

	Unknown Object (File)
	Thu, Dec 19, 1:44 PM

	Unknown Object (File)
	Fri, Dec 13, 10:46 PM

	Unknown Object (File)
	Sat, Nov 30, 4:29 AM

	Unknown Object (File)
	Nov 18 2024, 6:33 AM

	Unknown Object (File)
	Nov 13 2024, 11:47 PM

Subscribers

Details

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP310373ebc43f: Audit - delete duplicate audit requests and add unique key

Summary

Fixes T1768. This is mostly a data cleanliness issue as duplicate rows don't really do anything, but let's clear it up now.

Test Plan

made some duplicate rows by adding the same auditor multiple times. ran ./bin/storage upgrade and it worked perfectly!

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26045.Nov 14 2014, 12:06 AM

btrahan added a task: Restricted Maniphest Task.

btrahan retitled this revision from to Audit - delete duplicate audit requests and add unique key.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 14 2014, 12:06 AM

Harbormaster completed remote builds in B3046: Diff 26045.Nov 14 2014, 12:07 AM

btrahan added inline comments.Nov 14 2014, 12:07 AM

resources/sql/autopatches/20141113.auditdupes.php
2–25	the algorithm is "keep the first one from the liskmigrationiterator"

Yep, perfect. Rule seems reasonable to me.

resources/sql/autopatches/20141113.auditdupes.php
21	Technically redundant.
src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php
30	Maybe call this `key_unique` or something -- I've been trying to move names to `key_...` to make them unambiguous vs columns.

This revision is now accepted and ready to land.Nov 14 2014, 12:10 AM

Closed by commit rP310373ebc43f: Audit - delete duplicate audit requests and add unique key (authored by btrahan, committed by btrahan). · Explain WhyNov 14 2014, 12:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20141113.auditdupes.php

22 lines

src/

applications/

repository/

storage/

PhabricatorRepositoryAuditRequest.php

4 lines

Diff 26046

resources/sql/autopatches/20141113.auditdupes.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php

Loading...