Page MenuHomePhabricator
Differential D10846

Fix "edit multiple reviewers" string
ClosedPublic
Actions

Authored by epriestley on Nov 13 2014, 4:46 PM.
Tags
None
Referenced Files
F14865596: D10846.id26037.diff
Sat, Feb 8, 12:05 AM
F14865595: D10846.id26036.diff
Sat, Feb 8, 12:05 AM
F14865594: D10846.id.diff
Sat, Feb 8, 12:05 AM
F14865593: D10846.diff
Sat, Feb 8, 12:05 AM
Unknown Object (File)
Mon, Feb 3, 3:54 AM
Unknown Object (File)
Sun, Feb 2, 5:03 AM
Unknown Object (File)
Sun, Feb 2, 2:00 AM
Unknown Object (File)
Thu, Jan 30, 10:52 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T6543: Commandeer transaction might be built wrong or have wrong display strings?
Commits
Restricted Diffusion Commit
rPe05d02375309: Fix "edit multiple reviewers" string
Summary

Fixes T6543. This was slightly trickier than I thought.

The actual inputs to this are: author, total affected count, added count, added list, removed count, removed list.

We weren't accounting for "total affected count" (used to select the correct word for "reviewers", e.g. "reviewers-few" vs "reviewers-many").

Test Plan

Screen_Shot_2014-11-13_at_8.46.15_AM.png (71×454 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Branch
reviewers
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3040
Build 3046: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26036.Nov 13 2014, 4:46 PM
epriestley retitled this revision from to Fix "edit multiple reviewers" string.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T6543: Commandeer transaction might be built wrong or have wrong display strings?.
Herald added a subscriber: epriestley. · View Herald TranscriptNov 13 2014, 4:46 PM
Harbormaster completed remote builds in B3040: Diff 26036.Nov 13 2014, 4:47 PM
chad accepted this revision.Nov 13 2014, 4:47 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 13 2014, 4:47 PM
Closed by commit rPe05d02375309: Fix "edit multiple reviewers" string (authored by epriestley, committed by epriestley). · Explain WhyNov 13 2014, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
internationalization/
translation/
2 lines

Diff 26036

View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility