Page MenuHomePhabricator

Config - improve lock message for option `phabricator.uninstalled-applications`
ClosedPublic

Authored by btrahan on Nov 12 2014, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 5:05 PM
Unknown Object (File)
Feb 11 2024, 5:55 AM
Unknown Object (File)
Feb 5 2024, 12:11 PM
Unknown Object (File)
Jan 11 2024, 9:05 PM
Unknown Object (File)
Jan 10 2024, 3:50 PM
Unknown Object (File)
Jan 7 2024, 11:41 AM
Unknown Object (File)
Dec 25 2023, 11:39 AM
Unknown Object (File)
Dec 25 2023, 11:39 AM
Subscribers
Tokens
"Like" token, awarded by epriestley.

Details

Summary

Fixes T6175. This particular option is only editable via the Applications application so let the user know that.

Test Plan

saw error message and clicked through to applications app. tried another locked option and saw old message

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Config - improve lock message for option `phabricator.uninstalled-applications`.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
src/applications/config/option/PhabricatorCoreConfigOptions.php
30

i dont have't base-uri set on my install and everything seems to work fine... Unless of course I do a PhabricatorEnv::getURI() here, in which case I get an error about now having base-uri set.

Long story short, I think this raw uri string here is correct?

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/config/option/PhabricatorCoreConfigOptions.php
30

Yep, this is good.

This revision is now accepted and ready to land.Nov 12 2014, 7:31 PM
This revision was automatically updated to reflect the committed changes.