Differential D10841

Config - improve lock message for option `phabricator.uninstalled-applications`
ClosedPublic
Actions

Authored by btrahan on Nov 12 2014, 7:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 24, 2:02 PM

	Unknown Object (File)
	Thu, Dec 19, 1:42 PM

	Unknown Object (File)
	Thu, Dec 19, 1:42 PM

	Unknown Object (File)
	Thu, Dec 19, 1:42 PM

	Unknown Object (File)
	Wed, Dec 11, 12:07 AM

	Unknown Object (File)
	Thu, Dec 5, 6:11 PM

	Unknown Object (File)
	Sat, Nov 30, 6:31 PM

	Unknown Object (File)
	Sat, Nov 30, 6:23 PM

Subscribers

Tokens

"Like" token, awarded by epriestley.

Details

Reviewers

Maniphest Tasks

T6175: `phabricator.uninstalled-applications` is confusing because it isn't editable configuration

Commits

Restricted Diffusion Commit
rPaeb3a12e13ae: Config - improve lock message for option `phabricator.uninstalled-applications`

Summary

Fixes T6175. This particular option is only editable via the Applications application so let the user know that.

Test Plan

saw error message and clicked through to applications app. tried another locked option and saw old message

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26021.Nov 12 2014, 7:20 PM

btrahan added a task: T6175: `phabricator.uninstalled-applications` is confusing because it isn't editable configuration.

btrahan retitled this revision from to Config - improve lock message for option `phabricator.uninstalled-applications`.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 12 2014, 7:20 PM

Harbormaster completed remote builds in B3029: Diff 26021.Nov 12 2014, 7:20 PM

btrahan added inline comments.Nov 12 2014, 7:21 PM

src/applications/config/option/PhabricatorCoreConfigOptions.php
30	i dont have't base-uri set on my install and everything seems to work fine... Unless of course I do a PhabricatorEnv::getURI() here, in which case I get an error about now having base-uri set. Long story short, I think this raw uri string here is correct?

epriestley accepted this revision.Nov 12 2014, 7:31 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/config/option/PhabricatorCoreConfigOptions.php
30	Yep, this is good.

This revision is now accepted and ready to land.Nov 12 2014, 7:31 PM

epriestley awarded a token.Nov 12 2014, 7:31 PM

Closed by commit rPaeb3a12e13ae: Config - improve lock message for option `phabricator.uninstalled-applications` (authored by btrahan, committed by btrahan). · Explain WhyNov 12 2014, 7:32 PM

This revision was automatically updated to reflect the committed changes.

chad mentioned this in T6779: phabricator.uninstalled-applications Is locked even though nothing is uninstalled.Dec 18 2014, 7:22 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

controller/

PhabricatorConfigEditController.php

4 lines

option/

PhabricatorConfigOption.php

15 lines

PhabricatorCoreConfigOptions.php

9 lines

Diff 26022

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...

src/applications/config/option/PhabricatorConfigOption.php

Loading...

src/applications/config/option/PhabricatorCoreConfigOptions.php

Loading...