Page MenuHomePhabricator
Differential D10837

Phriction - fix "unknown policy" on document create
ClosedPublic
Actions

Authored by btrahan on Nov 12 2014, 2:15 AM.
Tags
None
Referenced Files
F14414846: D10837.id26010.diff
Tue, Dec 24, 4:25 PM
Unknown Object (File)
Thu, Dec 19, 4:25 PM
Unknown Object (File)
Thu, Dec 19, 4:25 PM
Unknown Object (File)
Thu, Dec 19, 4:25 PM
Unknown Object (File)
Thu, Dec 19, 1:42 PM
Unknown Object (File)
Wed, Dec 11, 6:23 AM
Unknown Object (File)
Sat, Dec 7, 9:26 AM
Unknown Object (File)
Wed, Dec 4, 6:10 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Evil Spooky Haunted Tree" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy
Commits
Restricted Diffusion Commit
rP36c46d80f5a0: Phriction - fix "unknown policy" on document create
Summary

when creating new documents the policy object wasn't being initialized properly. update the code to use the new handy initializeNewDocument method. Fixes T6527.

Test Plan

viewed a doc at /w/asdsadsadsdas/ and saw the correct policy setting

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26009.Nov 12 2014, 2:15 AM
btrahan added a task: T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.
btrahan retitled this revision from to Phriction - fix "unknown policy" on document create.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 12 2014, 2:15 AM
epriestley accepted this revision.Nov 12 2014, 2:15 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 12 2014, 2:15 AM
epriestley awarded a token.Nov 12 2014, 2:16 AM
Harbormaster completed remote builds in B3023: Diff 26009.Nov 12 2014, 2:16 AM
Closed by commit rP36c46d80f5a0: Phriction - fix "unknown policy" on document create (authored by btrahan, committed by btrahan). · Explain WhyNov 12 2014, 2:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
controller/
2 lines

Diff 26010

View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
Phabricator · Built by Phacility