Differential D10833

Config migration script bug fix
ClosedPublic
Actions

Authored by btrahan on Nov 11 2014, 11:03 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T6508: Exception thrown when using `./bin/config migrate`

Commits

Restricted Diffusion Commit
rP755c5186318b: Config migration script bug fix

Summary

i think way back in D10490 I didn't incorporate feedback correctly. make this code right as it fatals in this codepath as is. Fixes T6508.

Test Plan

@joshuaspence to the rescue (I remain unable to test this effectively with my baby-clean installation.)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26000.Nov 11 2014, 11:03 PM

btrahan added a task: T6508: Exception thrown when using `./bin/config migrate`.

btrahan retitled this revision from to Config migration script bug fix.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a subscriber: joshuaspence.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 11 2014, 11:03 PM

Harbormaster completed remote builds in B3016: Diff 26000.Nov 11 2014, 11:04 PM

epriestley accepted this revision.Nov 11 2014, 11:04 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 11 2014, 11:04 PM

Closed by commit rP755c5186318b: Config migration script bug fix (authored by btrahan, committed by btrahan). · Explain WhyNov 11 2014, 11:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

management/

PhabricatorConfigManagementMigrateWorkflow.php

7 lines

Diff 26001

View Options

src/applications/config/management/PhabricatorConfigManagementMigrateWorkflow.php

Config migration script bug fixClosedPublicActions