Page MenuHomePhabricator

Phriction - kill the old PhrictionDocumentEditor
ClosedPublic

Authored by btrahan on Nov 5 2014, 10:02 PM.

Details

Summary

Ref T4029. Long live PhrictionTransactionEditor...! this means that all existing functionality runs 100% through the modern transactions + editor framework. this diff does a few things in sum

  • kills the old editor
  • moves conduit-based edits to new editor
  • moves stubbing out documents to new editor
  • deletes moving of wiki docs for projects functionality... (T4021#59511 is a better bigger battle plan here.)
Test Plan

edited a phriction document via conduit and it worked. created a new phriction document /that/was/deep/ and verified ancestral documents were properly stubbed out. changed a project name and noted no wiki page moves.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Phriction - kill the old PhrictionDocumentEditor.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
src/applications/phriction/query/PhrictionDocumentQuery.php
211 ↗(On Diff #25896)

whoops, will purge

epriestley edited edge metadata.

This puts project pages in a slightly more awkward spot, but that seems reasonable until we can dig them out of the automagic mess.

This revision is now accepted and ready to land.Nov 6 2014, 8:25 PM
This revision was automatically updated to reflect the committed changes.