Page MenuHomePhabricator
Differential D10784

Make default and hidden columns in Workboards more clear
ClosedPublic
Actions

Authored by chad on Nov 4 2014, 6:15 PM.
Tags
None
Referenced Files
F14011142: D10784.id25879.diff
Thu, Oct 31, 7:49 PM
F13984418: D10784.id25879.diff
Sun, Oct 20, 1:15 PM
F13970616: D10784.id.diff
Oct 17 2024, 8:47 AM
F13962724: D10784.id25880.diff
Oct 15 2024, 11:55 AM
Unknown Object (File)
Oct 5 2024, 7:19 PM
Unknown Object (File)
Oct 4 2024, 5:55 PM
Unknown Object (File)
Oct 1 2024, 8:11 AM
Unknown Object (File)
Sep 30 2024, 7:27 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6469: Make it more clear which Workboard Column is 'default'
Commits
Restricted Diffusion Commit
rP7a6684b73bfe: Make default and hidden columns in Workboards more clear
Summary

Fixes T6469. Changes the default icon into text instead. Added the text to hidden boards and now display when reordering as well.

Test Plan

Moved a bunch of columns, tested reordering. Seems more clear.

pasted_file (236×674 px, 54 KB)

pasted_file (413×653 px, 42 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 25879.Nov 4 2014, 6:15 PM
chad retitled this revision from to Make default and hidden columns in Workboards more clear.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T6469: Make it more clear which Workboard Column is 'default'.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 4 2014, 6:15 PM
Harbormaster completed remote builds in B2946: Diff 25879.Nov 4 2014, 6:16 PM
chad edited the test plan for this revision. (Show Details)Nov 4 2014, 6:16 PM
chad updated this revision to Diff 25880.Nov 4 2014, 6:18 PM
  • Unused
  • leafy
Harbormaster completed remote builds in B2947: Diff 25880.Nov 4 2014, 6:18 PM
chad added inline comments.Nov 4 2014, 6:19 PM
webroot/rsrc/css/phui/phui-object-item-list-view.css
274

It looks like we're applying margin to all ul elements in aphront-dialog. I'll have to follow up with another diff to clear all that out and remove this rule.

epriestley accepted this revision.Nov 4 2014, 7:00 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2014, 7:00 PM
Closed by commit rP7a6684b73bfe: Make default and hidden columns in Workboards more clear (authored by chad, committed by chad). · Explain WhyNov 4 2014, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
project/
controller/
3 lines
1 line
storage/
16 lines
view/
phui/
17 lines
7 lines
webroot/
rsrc/
css/
layout/
phui/
layout/
phui-action-header-view.css
phabricator-action-header-view.css
8 lines
phui/
4 lines

Diff 25881

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardReorderController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumn.php

Loading...
View Options

src/view/phui/PHUIActionHeaderView.php

Loading...
View Options

src/view/phui/PHUIWorkpanelView.php

Loading...
View Options

webroot/rsrc/css/layout/phabricator-action-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-action-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility