Page MenuHomePhabricator

Make default and hidden columns in Workboards more clear
ClosedPublic

Authored by chad on Nov 4 2014, 6:15 PM.
Tags
None
Referenced Files
F12846623: D10784.id25880.diff
Fri, Mar 29, 1:21 AM
Unknown Object (File)
Sun, Mar 10, 1:57 AM
Unknown Object (File)
Feb 6 2024, 5:28 PM
Unknown Object (File)
Feb 1 2024, 6:46 PM
Unknown Object (File)
Jan 28 2024, 6:47 PM
Unknown Object (File)
Jan 28 2024, 3:06 AM
Unknown Object (File)
Jan 27 2024, 10:48 PM
Unknown Object (File)
Jan 27 2024, 10:12 PM
Subscribers

Details

Summary

Fixes T6469. Changes the default icon into text instead. Added the text to hidden boards and now display when reordering as well.

Test Plan

Moved a bunch of columns, tested reordering. Seems more clear.

pasted_file (236×674 px, 54 KB)

pasted_file (413×653 px, 42 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Make default and hidden columns in Workboards more clear.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
webroot/rsrc/css/phui/phui-object-item-list-view.css
274

It looks like we're applying margin to all ul elements in aphront-dialog. I'll have to follow up with another diff to clear all that out and remove this rule.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2014, 7:00 PM
This revision was automatically updated to reflect the committed changes.