Fix wrong subclass in ConfigIgnore controller
ClosedPublic
Actions

Authored by epriestley on Oct 30 2014, 10:30 PM.

Details

Reviewers

btrahan
• austinstoker

Maniphest Tasks

T6436: Configuration issues can be ignored by non-admins

Commits

Restricted Diffusion Commit
rP4a00e476460f: Fix wrong subclass in ConfigIgnore controller

Summary

Fixes T6436. We subclass the wrong controller and miss the admin-only check.

Test Plan

Ignored / unignored set up issues.

Diff Detail

Repository

rP Phabricator

Branch

ignoreadmin

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2921
Build 2925: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25840.Oct 30 2014, 10:30 PM

epriestley retitled this revision from to Fix wrong subclass in ConfigIgnore controller.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6436: Configuration issues can be ignored by non-admins.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 30 2014, 10:30 PM

Harbormaster completed remote builds in B2921: Diff 25840.Oct 30 2014, 10:31 PM

(I also checked all the other controllers.)

btrahan accepted this revision.Oct 30 2014, 10:32 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2014, 10:32 PM

Closed by commit rP4a00e476460f: Fix wrong subclass in ConfigIgnore controller (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2014, 10:33 PM

This revision was automatically updated to reflect the committed changes.

• austinstoker added a reviewer: • austinstoker.Oct 31 2014, 5:53 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

controller/

PhabricatorConfigIgnoreController.php

2 lines

Diff 25840

View Options

src/applications/config/controller/PhabricatorConfigIgnoreController.php

Fix wrong subclass in ConfigIgnore controllerClosedPublicActions