Page MenuHomePhabricator

Widen scope of ArcanistLintEngine::buildLinters
Needs ReviewPublic

Authored by Firehed on Oct 16 2014, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 3:17 PM
Unknown Object (File)
Fri, Dec 6, 4:26 AM
Unknown Object (File)
Wed, Dec 4, 9:23 PM
Unknown Object (File)
Tue, Dec 3, 4:29 PM
Unknown Object (File)
Sun, Dec 1, 7:33 AM
Unknown Object (File)
Tue, Nov 26, 6:34 PM
Unknown Object (File)
Fri, Nov 22, 11:03 PM
Unknown Object (File)
Tue, Nov 19, 10:37 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

When the arc linters workflow was added, it added a dependency on this method being public. If you create a new lint engine with the scope set to protected (as in the parent) and specify that linter in your .arcconfig file, arc linters would fatal error out with a message like:

Fatal error: Call to protected method Firehed\Arctools\LintEngine::buildLinters() from context 'ArcanistLintersWorkflow' in /Users/firehed/dev/arcanist/src/workflow/ArcanistLintersWorkflow.php on line 44

Call Stack:
    0.0007     332136   1. {main}() /Users/firehed/dev/arcanist/scripts/arcanist.php:0
    0.0354    6939256   2. ArcanistLintersWorkflow->run() /Users/firehed/dev/arcanist/scripts/arcanist.php:338
Test Plan

ran arc linters after the change (and adjusted the scope of my own subclass accordingly) and saw the expected output

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2853
Build 2857: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

Firehed retitled this revision from to Widen scope of ArcanistLintEngine::buildLinters.
Firehed updated this object.
Firehed edited the test plan for this revision. (Show Details)
Firehed added a reviewer: epriestley.