Page MenuHomePhabricator

Build AlmanacDevice UI
ClosedPublic

Authored by epriestley on Oct 16 2014, 6:20 PM.
Tags
None
Referenced Files
F14059431: D10714.diff
Sun, Nov 17, 7:38 PM
F14036261: D10714.diff
Sun, Nov 10, 9:23 AM
F14033552: D10714.id25725.diff
Sat, Nov 9, 6:11 PM
F14033080: D10714.id25725.diff
Sat, Nov 9, 4:37 PM
F14021609: D10714.diff
Wed, Nov 6, 10:07 AM
Unknown Object (File)
Oct 10 2024, 12:53 AM
Unknown Object (File)
Oct 1 2024, 9:18 PM
Unknown Object (File)
Sep 21 2024, 5:53 PM
Subscribers

Details

Summary

Ref T5833. The "uninteresting" part of this object is virtually identical to AlmanacService.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Branch
host5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2850
Build 2854: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Build AlmanacDevice UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

How come so much effort on name formatting?

This revision is now accepted and ready to land.Oct 17 2014, 12:11 AM

I intend them to be a primary identifier (and basically work in a way similar to domain names), and possibly have some logic around "a.b.c" being a child of "a.b", so I don't want people naming them stuff like ??..., which might be impossible to resolve meaningfully. Might be overkill but I figured it's easier to lock them down to start out with.

This revision was automatically updated to reflect the committed changes.