Page MenuHomePhabricator
Differential D10699

Transactions - fix doorkeeper feed story error
ClosedPublic
Actions

Authored by btrahan on Oct 13 2014, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 10:47 PM
Unknown Object (File)
Sat, Feb 15, 10:10 PM
Unknown Object (File)
Fri, Feb 14, 12:51 PM
Unknown Object (File)
Mon, Feb 10, 3:40 AM
Unknown Object (File)
Fri, Feb 7, 11:47 PM
Unknown Object (File)
Fri, Feb 7, 11:47 PM
Unknown Object (File)
Fri, Feb 7, 11:47 PM
Unknown Object (File)
Fri, Feb 7, 11:47 PM
View All Files
Subscribers
avivey
epriestley
Korvin

Details

Reviewers
epriestley
avivey
Maniphest Tasks
T6300: publish to JIRA requires a handle it did not load
Commits
Restricted Diffusion Commit
rP7d9eb8baaf86: Transactions - fix doorkeeper feed story error
Summary

missing a setHandles on this codepath I think...? Fixes T6300.

Test Plan

not actually tested - I just think this is the fix since the other renderX methods all do this setHandles thing and I can't figure out how handles get set otherwise...

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25688.Oct 13 2014, 10:09 PM
btrahan added a task: T6300: publish to JIRA requires a handle it did not load.
btrahan retitled this revision from to Transactions - fix doorkeeper feed story error.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 13 2014, 10:09 PM
Harbormaster completed remote builds in B2826: Diff 25688.Oct 13 2014, 10:09 PM
epriestley accepted this revision.Oct 13 2014, 10:12 PM
epriestley edited edge metadata.

If we get another complaint I can break out my JIRA install and actually test this, but I'm pretty sure you're right.

This revision is now accepted and ready to land.Oct 13 2014, 10:12 PM
avivey added a subscriber: avivey.Oct 13 2014, 10:15 PM

I'll try patching it here...

avivey accepted this revision.Oct 13 2014, 10:20 PM
avivey added a reviewer: avivey.

Yeah, it cleared all jira jobs without errors with this.

Closed by commit rP7d9eb8baaf86: Transactions - fix doorkeeper feed story error (authored by btrahan, committed by btrahan).Oct 13 2014, 11:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
feed/
4 lines

Diff 25692

View Options

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

Loading...
Phabricator · Built by Phacility