Page MenuHomePhabricator

Storage - escape collation type in create database code pathway
ClosedPublic

Authored by btrahan on Oct 6 2014, 7:54 PM.
Tags
None
Referenced Files
F15541436: D10641.id25554.diff
Fri, Apr 25, 12:00 PM
F15527515: D10641.diff
Tue, Apr 22, 4:14 AM
F15506063: D10641.id25554.diff
Tue, Apr 15, 8:20 AM
F15495116: D10641.id25555.diff
Sun, Apr 13, 2:49 AM
F15494711: D10641.id25555.diff
Sun, Apr 13, 1:24 AM
F15492312: D10641.id.diff
Sat, Apr 12, 1:14 PM
F15491719: D10641.id25554.diff
Sat, Apr 12, 6:47 AM
F15491579: D10641.id.diff
Sat, Apr 12, 5:05 AM
Subscribers

Details

Summary

without escapage here, creating databases fails. Fixes T6251.

Test Plan

ran the command CREATE DATABASE foo COLLATION binary and it failed; ran the command CREATE DATABASE foo2 COLLATION "binary" and it worked; trusting that the %T still works as advertised.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Storage - escape collation type in create database code pathway.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2014, 7:57 PM
This revision was automatically updated to reflect the committed changes.