Storage - escape collation type in create database code pathway
ClosedPublic
Actions

Authored by btrahan on Oct 6 2014, 7:54 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6251: Create Database fails with a AphrontQueryException 1064

Commits

Restricted Diffusion Commit
rP928b4edffb66: Storage - escape collation type in create database code pathway

Summary

without escapage here, creating databases fails. Fixes T6251.

Test Plan

ran the command CREATE DATABASE foo COLLATION binary and it failed; ran the command CREATE DATABASE foo2 COLLATION "binary" and it worked; trusting that the %T still works as advertised.

Diff Detail

Repository

rP Phabricator

Branch

T6251

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2753
Build 2757: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25554.Oct 6 2014, 7:54 PM

btrahan added a task: T6251: Create Database fails with a AphrontQueryException 1064.

btrahan retitled this revision from to Storage - escape collation type in create database code pathway.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 6 2014, 7:54 PM

Harbormaster completed remote builds in B2753: Diff 25554.Oct 6 2014, 7:54 PM

epriestley accepted this revision.Oct 6 2014, 7:57 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 6 2014, 7:57 PM

Closed by commit rP928b4edffb66: Storage - escape collation type in create database code pathway (authored by btrahan, committed by btrahan).Oct 6 2014, 7:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

PhabricatorStorageManagementAPI.php

2 lines

Diff 25554

View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Storage - escape collation type in create database code pathwayClosedPublicActions