Allow adding Auditors with the singular noun.
ClosedPublic
Actions

Authored by SiebelsTim on Oct 6 2014, 12:50 PM.

Tags

None

Referenced Files

	F18855433: D10636.diff
	Nov 1 2025, 5:16 AM

	F18823755: D10636.id25544.diff
	Oct 23 2025, 1:14 PM

	F18790444: D10636.id30982.diff
	Oct 15 2025, 2:32 PM

	F18703850: D10636.diff
	Sep 28 2025, 5:15 AM

	F18693382: D10636.diff
	Sep 27 2025, 12:47 AM

	F18583023: D10636.id25544.diff
	Sep 11 2025, 9:16 AM

	F18582765: D10636.diff
	Sep 11 2025, 8:55 AM

	F18582500: D10636.id30982.diff
	Sep 11 2025, 8:32 AM

View All Files

Subscribers

epriestley

joshuaspence

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP00136f05dd6d: Allow adding Auditors with the singular noun.

Summary

Currently adding auditors in commit message only works with the plural. Make "Auditor: bla" work.

Test Plan

Unit tests. I don't know if I am supposed to add a test.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

SiebelsTim updated this revision to Diff 25544.Oct 6 2014, 12:50 PM

SiebelsTim retitled this revision from to Allow adding Auditors with the singular noun..

SiebelsTim updated this object.

SiebelsTim edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 6 2014, 12:50 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2747: Diff 25544.Oct 6 2014, 12:51 PM

joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 11:59 PM

epriestley accepted this revision.May 17 2015, 2:18 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.May 17 2015, 2:18 PM

Closed by commit rP00136f05dd6d: Allow adding Auditors with the singular noun. (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2015, 2:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

2 lines

Diff 30982

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Allow adding Auditors with the singular noun.ClosedPublicActions