Page MenuHomePhabricator
Differential D10625

Fix TokenGiven stories for Asana
ClosedPublic
Actions

Authored by epriestley on Oct 2 2014, 4:11 PM.
Tags
None
Referenced Files
F18790514: D10625.id25507.diff
Wed, Oct 15, 3:10 PM
F18763110: D10625.id.diff
Mon, Oct 6, 10:45 PM
F18761944: D10625.id25506.diff
Mon, Oct 6, 4:58 PM
F18755657: D10625.diff
Sun, Oct 5, 6:48 AM
F18754926: D10625.id.diff
Sun, Oct 5, 2:26 AM
F18739057: D10625.id25506.diff
Wed, Oct 1, 7:23 PM
F18712207: D10625.diff
Sep 29 2025, 5:18 AM
F18687244: D10625.diff
Sep 26 2025, 2:12 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6201: Inline comment text not publishing into Asana
Commits
Restricted Diffusion Commit
rP7018909447f3: Fix TokenGiven stories for Asana
Summary

Ref T6201. This isn't quite perfect but should be good enough. At some point far in the future I plan to revamp feed rendering a bit. This should possibly become a real ApplicationTransaction story eventually, too.

Test Plan

Screen_Shot_2014-10-02_at_9.10.49_AM.png (208×503 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Branch
tokenstor
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php:58XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 2723
Build 2727: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25506.Oct 2 2014, 4:11 PM
epriestley retitled this revision from to Fix TokenGiven stories for Asana.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6201: Inline comment text not publishing into Asana.
Herald added a subscriber: epriestley. · View Herald TranscriptOct 2 2014, 4:11 PM
Harbormaster completed remote builds in B2723: Diff 25506.Oct 2 2014, 4:11 PM
chad accepted this revision.Oct 2 2014, 4:17 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Oct 2 2014, 4:17 PM
Closed by commit rP7018909447f3: Fix TokenGiven stories for Asana (authored by epriestley, committed by epriestley).Oct 2 2014, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
tokens/
feed/
9 lines

Diff 25506

View Options

src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php

Loading...
Phabricator · Built by Phacility