Fix TokenGiven stories for Asana
ClosedPublic
Actions

Authored by epriestley on Oct 2 2014, 4:11 PM.

Tags

None

Referenced Files

	F19502780: D10625.id.diff
	Thu, Jan 8, 7:23 PM

	F19046894: D10625.diff
	Nov 27 2025, 11:54 AM

	F18907201: D10625.id.diff
	Nov 8 2025, 10:23 PM

	F18906003: D10625.id25506.diff
	Nov 8 2025, 4:30 PM

	F18887401: D10625.diff
	Nov 7 2025, 5:58 AM

	F18857714: D10625.id25506.diff
	Nov 1 2025, 5:14 PM

	F18854462: D10625.id.diff
	Nov 1 2025, 12:19 AM

	F18790514: D10625.id25507.diff
	Oct 15 2025, 3:10 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6201: Inline comment text not publishing into Asana

Commits

Restricted Diffusion Commit
rP7018909447f3: Fix TokenGiven stories for Asana

Summary

Ref T6201. This isn't quite perfect but should be good enough. At some point far in the future I plan to revamp feed rendering a bit. This should possibly become a real ApplicationTransaction story eventually, too.

Test Plan

Screen_Shot_2014-10-02_at_9.10.49_AM.png (208×503 px, 20 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25506.Oct 2 2014, 4:11 PM

epriestley retitled this revision from to Fix TokenGiven stories for Asana.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6201: Inline comment text not publishing into Asana.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 2 2014, 4:11 PM

Harbormaster completed remote builds in B2723: Diff 25506.Oct 2 2014, 4:11 PM

chad accepted this revision.Oct 2 2014, 4:17 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Oct 2 2014, 4:17 PM

Closed by commit rP7018909447f3: Fix TokenGiven stories for Asana (authored by epriestley, committed by epriestley).Oct 2 2014, 4:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

tokens/

feed/

PhabricatorTokenGivenFeedStory.php

9 lines

Diff 25507

View Options

src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php

Fix TokenGiven stories for AsanaClosedPublicActions