Page MenuHomePhabricator

Support AUTO_INCREMENT in `bin/storage adjust`
ClosedPublic

Authored by epriestley on Sep 29 2014, 7:17 PM.
Tags
None
Referenced Files
F19630119: D10607.diff
Feb 5 2026, 1:28 AM
F19503711: D10607.diff
Jan 9 2026, 1:21 AM
F19503710: D10607.diff
Jan 9 2026, 1:21 AM
F19503678: D10607.diff
Jan 9 2026, 1:06 AM
F19152991: D10607.id25477.diff
Dec 11 2025, 6:37 AM
F19152687: D10607.id25477.diff
Dec 11 2025, 4:23 AM
F19132653: D10607.id25449.diff
Dec 10 2025, 6:19 AM
F19111963: D10607.diff
Dec 9 2025, 4:53 PM
Subscribers

Details

Summary

Ref T1191. When changing the column type of an AUTO_INCREMENT column, we currently may lose the autoincrement attribute.

Instead, support it. This is a bit messy because AUTO_INCREMENT columns interact with PRIMARY KEY columns (tables may only have one AUTO_INCREMENT column, and it must be a primary key). We need to migrate in more phases to avoid this issue.

Introduce new auto and auto64 types to represent autoincrement IDs.

Test Plan
  • Saw autoincrement show up correctly in web UI.
  • Fixed an autoincrement issue on the XHProf storage table with bin/storage adjust safely.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support AUTO_INCREMENT in `bin/storage adjust`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 5:08 PM
This revision was automatically updated to reflect the committed changes.