Page MenuHomePhabricator
Differential D10597

Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter`
ClosedPublic
Actions

Authored by joshuaspence on Sep 28 2014, 12:44 PM.
Tags
None
Referenced Files
F15463554: D10597.id.diff
Wed, Apr 2, 12:44 AM
F15461475: D10597.id25433.diff
Tue, Apr 1, 8:34 AM
F15427570: D10597.diff
Sun, Mar 23, 2:58 PM
F15403644: D10597.diff
Tue, Mar 18, 4:16 AM
F15403205: D10597.id25433.diff
Tue, Mar 18, 2:12 AM
F15294444: D10597.diff
Wed, Mar 5, 8:12 AM
Unknown Object (File)
Feb 28 2025, 2:29 AM
Unknown Object (File)
Jan 26 2025, 2:03 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCe54725ec8918: Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter`
Summary

Adds an ArcanistXHPASTLinter::LINT_CONSTRUCTOR_PARENTHESES rule which ensures that (possibly empty) parentheses are used when calling a constructor.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 25433.Sep 28 2014, 12:44 PM
joshuaspence retitled this revision from to Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 28 2014, 12:44 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2686: Diff 25433.Sep 28 2014, 12:45 PM
epriestley accepted this revision.Sep 28 2014, 12:53 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2014, 12:53 PM
joshuaspence updated this object.Oct 7 2014, 12:58 PM
joshuaspence edited edge metadata.
Closed by commit rARCe54725ec8918: Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter` (authored by joshuaspence, committed by joshuaspence).Oct 7 2014, 1:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
23 lines
__tests__/
xhpast/
12 lines

Diff 25574

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/constructor-parentheses.lint-test

Loading...
Phabricator · Built by Phacility