Differential D10584

Partially modernize Doorkeeper/Asana bridge
ClosedPublic
Actions

Authored by epriestley on Sep 27 2014, 12:45 AM.

Tags

None

Referenced Files

	F15438485: D10584.id25456.diff
	Wed, Mar 26, 12:59 AM

	F15396430: D10584.id25417.diff
	Sun, Mar 16, 2:13 PM

	F15378815: D10584.diff
	Thu, Mar 13, 5:12 PM

	F15357184: D10584.id25417.diff
	Tue, Mar 11, 6:36 AM

	F15308283: D10584.id25456.diff
	Mar 6 2025, 6:05 AM

	Unknown Object (File)
	Feb 12 2025, 4:12 AM

	Unknown Object (File)
	Feb 12 2025, 4:12 AM

	Unknown Object (File)
	Feb 12 2025, 4:12 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T6201: Inline comment text not publishing into Asana

Commits

Restricted Diffusion Commit
rP3fe226f9f037: Partially modernize Doorkeeper/Asana bridge

Summary

Fixes T6201. This stuff didn't fully get updated for ApplicationTransactions. Get it working again (notably, make inline comment text publish) and clean it up a little bit.

Test Plan

Published a Differential feed story into Asana with comment text.
Pulbished a Diffusion feed story into Asana with comment text.

Diff Detail

Repository

Branch

asana

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/storage/DifferentialTransaction.php:613	XHP16	TODO Comment
Advice	src/applications/feed/story/PhabricatorFeedStory.php:257	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 2671
Build 2675: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25417.Sep 27 2014, 12:45 AM

epriestley retitled this revision from to Partially modernize Doorkeeper/Asana bridge.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6201: Inline comment text not publishing into Asana.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 27 2014, 12:45 AM

Harbormaster completed remote builds in B2671: Diff 25417.Sep 27 2014, 12:45 AM

btrahan accepted this revision.Sep 30 2014, 4:45 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Sep 30 2014, 4:45 PM

Closed by commit rP3fe226f9f037: Partially modernize Doorkeeper/Asana bridge (authored by epriestley, committed by epriestley).Oct 1 2014, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

doorkeeper/

DifferentialDoorkeeperRevisionFeedStoryPublisher.php

12 lines

storage/

DifferentialTransaction.php

54 lines

diffusion/

doorkeeper/

DiffusionDoorkeeperCommitFeedStoryPublisher.php

12 lines

doorkeeper/

engine/

DoorkeeperFeedStoryPublisher.php

6 lines

feed/

constants/

PhabricatorFeedStoryTypeConstants.php

1 line

story/

PhabricatorFeedStory.php

11 lines

PhabricatorFeedStoryAudit.php

34 lines

PhabricatorFeedStoryDifferential.php

155 lines

transactions/

feed/

PhabricatorApplicationTransactionFeedStory.php

13 lines

storage/

PhabricatorApplicationTransaction.php

38 lines

Diff 25417

src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php

Loading...

src/applications/differential/storage/DifferentialTransaction.php

Loading...

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

Loading...

src/applications/doorkeeper/engine/DoorkeeperFeedStoryPublisher.php

Loading...

src/applications/feed/constants/PhabricatorFeedStoryTypeConstants.php

Loading...

src/applications/feed/story/PhabricatorFeedStory.php

Loading...

src/applications/feed/story/PhabricatorFeedStoryAudit.php

Loading...

src/applications/feed/story/PhabricatorFeedStoryDifferential.php

Loading...

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

Loading...

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...